Skip to content

[910] Pubsub service crashes on protocol negotiation failures #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[910] Pubsub service crashes on protocol negotiation failures #924

wants to merge 13 commits into from
+41 −3

Conversation

SuchitraSwain
Copy link

What was wrong?

Issue #910

How was it fixed?

Technical Approach

  1. Minimal Invasive Fix:
  • Added only a try-except block around the problematic line
  • No changes to the existing API or method signatures
  • Preserved all existing functionality
  1. Service Continuity:
  • The pubsub service now continues running even when individual peer negotiations fail
  • TCP connections are maintained even if PubSub protocol negotiation fails
  • Future peer connections can still be processed

To-Do

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@sumanjeet0012
Copy link
Contributor

@SuchitraSwain Please fix the CI CD issues.

@seetadev
Copy link
Contributor

@SuchitraSwain : Re-ran the CI/Cd pipeline. Please fix the issues.

@seetadev
Copy link
Contributor

@sumanjeet0012 : Hi Sumanjeet. Since, you nicely authored the pub sub example at the beginning of year, wish if you could help @SuchitraSwain arrive at a good conclusion on the issues.

@sumanjeet0012
Copy link
Contributor

@SuchitraSwain I have made some changes in tests and created a PR on your fork, and now the tests are passing on my local PC, Take a look at the Pubsub test fix. Please review the changes, and if everything works as expected on your end, you may go ahead and merge the PR.

@seetadev
Copy link
Contributor

@SuchitraSwain , @sumanjeet0012 : Re-ran the CI/CD pipeline. Lets review the test results too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SuchitraSwain @sumanjeet0012 @seetadev @yashksaini-coder